Accepted open-vm-tools 2:10.3.5-7 (source) into unstable
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA256
Format: 1.8
Date: Mon, 04 Mar 2019 20:02:52 +0100
Source: open-vm-tools
Binary: open-vm-tools open-vm-tools-desktop open-vm-tools-dev
Architecture: source
Version: 2:10.3.5-7
Distribution: unstable
Urgency: medium
Maintainer: Bernd Zeimetz <bzed@debian.org>
Changed-By: Bernd Zeimetz <bzed@debian.org>
Description:
open-vm-tools - Open VMware Tools for virtual machines hosted on VMware (CLI)
open-vm-tools-desktop - Open VMware Tools for virtual machines hosted on VMware (GUI)
open-vm-tools-dev - Open VMware Tools for virtual machines hosted on VMware (developm
Changes:
open-vm-tools (2:10.3.5-7) unstable; urgency=medium
.
[ Christian Ehrhardt ]
* [71b468f] make vgauth service execution more reliable.
Since d3d47039 "Start vgauth before vmtoolsd" there is a potential race
of starting vgauth so early that it might have issues. This was
discussed back in the day in [1] to [2], but confirmed to be ok by
VMWare.
We were all somewhat convinced by this, but a bad feeling remained not
only with me but also with Bernd [4].
A recent SRU review denial made me rethink all of it and I think we can
make it safer without thwarting the purpose of the original change.
Note: Disambiguation of service names used below:
vgauth - open-vm-tools.vgauth.service
vmtoolsd - open-vm-tools.service
fs - systemd-remount-fs.service
tmp - systemd-tmpfiles-setup.service
cloud-init - cloud-init-local.service
Currently we have these dependency requirements:
- vgauth should be before vmtoolsd
- cloud init should be before vmtoolsd
- cloud init has to be really early in general
- therefore this is using DefaultDependencies=No
That lead to this graph:
fs / tmp -> vmtoolsd -> cloud-init
And d3d47039 added it to be like:
fs / tmp -> vmtoolsd -> cloud-init
^
vgauth --|
But there is no need to have vgauth without any pre-dependencies at all.
It is only needed to be "before" vmtoolsd, therefore we can make it:
fs / tmp -> vgauth -> vmtoolsd -> cloud-init
That will make execution of vgauth much less error-prone (even though I
have no hard issue to report) while at the same time holding up all
known required ordering constraints.
[1]: https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1804287/comments/3
[2]: https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1804287/comments/12
[3]: https://bugs.launchpad.net/ubuntu/+source/open-vm-tools/+bug/1804287/comments/25
[4]: https://github.com/bzed/pkg-open-vm-tools/pull/15#issuecomment-447237910
Signed-off-by: Christian Ehrhardt <christian.ehrhardt@canonical.com>
Checksums-Sha1:
14a268210dc715b4147ce804b09c7103a0e6b420 2319 open-vm-tools_10.3.5-7.dsc
1b9bd0e0e665ce4d4f71bc370b06d99a07441a15 30916 open-vm-tools_10.3.5-7.debian.tar.xz
17e6509f6ba2a7564cc16e3ae377d52af0ae874f 16137 open-vm-tools_10.3.5-7_source.buildinfo
Checksums-Sha256:
ba1ae174980f38052f25f73c23c0492ff3e80e6f122bfe96ec2ea7c16146f0e2 2319 open-vm-tools_10.3.5-7.dsc
0c4677cd4da2aa50d50e66d3fbe6bdae6fc71e6f60501280de33c2ce32467410 30916 open-vm-tools_10.3.5-7.debian.tar.xz
46d5c45a01046e699836a64b2a8cc586de2a9de4c8dbdfd142a3b37486eaa6c5 16137 open-vm-tools_10.3.5-7_source.buildinfo
Files:
84f4d942639f4de86c801f45be6f8aa7 2319 admin extra open-vm-tools_10.3.5-7.dsc
d3e56d592e2c4b035f8e041210937d09 30916 admin extra open-vm-tools_10.3.5-7.debian.tar.xz
b3adc801409bdc9b92f4c9abde50ed61 16137 admin extra open-vm-tools_10.3.5-7_source.buildinfo
-----BEGIN PGP SIGNATURE-----
iQIzBAEBCAAdFiEE7KHj8o4RJDLUhd2V6zYXGm/5Q18FAlx9dssACgkQ6zYXGm/5
Q1/JUA/9F9FEIL/lRraS17n12514yr7NYjOXhMeWaA7cMWPAt51nsrs6zYEz4EIi
3vkiwALSI/LNAV7ZryF0xn2WPoD2FFeA1Y7SCXqaJ395DLQrqEf2/pEwyg0tL1H7
/j1SZQ87OywcbisO5t/w50xyYs/Jrh2DyrUtp7eWvWb2p5r8Vwnf0lnjBhbhiFnL
w0LyvxDXeD65tjHv58u2A9DGY6Bv4iZSFDPS/v2V/0IDlwKK/gDa1NS6Z7cjve1N
r8VfPPQbJch+IaHNUYaLhyafiS/U/yQL2IuEDwxR6/cFFEAnA0CEDxs1ZvIDUDoF
m3en+/FPI7+k1GOHNMwYk6TmOq21xUBCFImypqi+P9gAxApmUma4CMPEEFUBzz+y
MghzqEzQXa8yslH3fWeNazJC0Py7zBzEdGWHsUhBP6mz/zha6BzLjQrI+jTgrzX8
Qrg1b1l4s9z+hVW3XP+LOBDA5k56VPj0/ZScx9XaH91kQ6boxywPoRtnPpDj416W
I7KZBIYSHpW3gk2KtUZCweo0p8IAlEmWumcbXaaahRskJLflDdEPjN87wYzcjPLH
p1E3R8p70J/1OSglfxvxnxP4WufMI7W1oxdJFvA/2xiT/KCz9mOPOSCDyVgQ+pTo
i9p7irKkkTjEeZiMBxRmkV5grgrcsYdCF1Qo077OZxo2qJv5MVc=
=9O+/
-----END PGP SIGNATURE-----